Use Task generally over Command
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially in places where we call `.output()`, what we generally always want is to get stdout, but keep stderr going to the parent process stderr. The `Command` API doesn't make this obvious to do, and worse forces every caller to manually check the exit status. The `Task` API fixes both of these. (Now, the Task API also defaults to printing a description, which we need suppress in many cases with `.quiet()`) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
command-use-task
branch
from
1f394dc to
d749a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially in places where we call
.output(), what we generally always want is to get stdout, but keep stderr going to the parent process stderr. TheCommandAPI doesn't make this obvious to do, and worse forces every caller to manually check the exit status.The
TaskAPI fixes both of these.(Now, the Task API also defaults to printing a description,
which we need suppress in many cases with
.quiet())